Fix String.endsWith returning false negatives #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengjeffrey
force-pushed
the
fix/string-endsWith
branch
from
51e83d6 to
9cff87f
Compare
dengjeffrey
force-pushed
the
fix/string-endsWith
branch
from
9cff87f to
5a6c697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to solve:
Previous implementation of
String.endsWith(str, substr)returns false if the the string provided contained more than one instance of the substring.This PR tries to solve this problem by comparing the suffix of the original string against the substring the user is looking for.
This PR does not use
String.endsWithadded in ECMA6, so that targaryen is still compatible with node 4Testing
Added edge case test to
string-methods.jstest spec